Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch work forever if timeout is not specified #30

Merged
merged 4 commits into from
Jul 28, 2018

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Jul 28, 2018

Related to: #29

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #30 into master will decrease coverage by 0.35%.
The diff coverage is 84.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   93.48%   93.13%   -0.36%     
==========================================
  Files          16       16              
  Lines         967      990      +23     
==========================================
+ Hits          904      922      +18     
- Misses         63       68       +5
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch_test.py 96.25% <100%> (+0.47%) ⬆️
kubernetes_asyncio/watch/watch.py 87.67% <78.26%> (-5.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e3374...ef5152a. Read the comment docs.

@tomplus tomplus merged commit e375f02 into master Jul 28, 2018
@tomplus tomplus deleted the feat/watch-forever branch October 12, 2018 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants