Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic package to setup.py and __init__.py #266

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add dynamic package to setup.py and __init__.py #266

merged 1 commit into from
Aug 3, 2023

Conversation

Jean-Daniel
Copy link
Contributor

It fix missing package issue when using pip install, and make it consistent with other packages.

@bobh66
Copy link
Contributor

bobh66 commented Aug 3, 2023

Thanks @Jean-Daniel !

Copy link
Owner

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90392de) 24.66% compared to head (1702ad5) 24.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   24.66%   24.67%           
=======================================
  Files         736      736           
  Lines       99024    99025    +1     
=======================================
+ Hits        24429    24430    +1     
  Misses      74595    74595           
Files Changed Coverage Δ
kubernetes_asyncio/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomplus tomplus merged commit 0a0f840 into tomplus:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants