Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch returns raw_object if detection of returned objects fail #177

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Jan 30, 2022

Closes #176

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #177 (7d86e52) into master (f2b270d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   30.34%   30.34%           
=======================================
  Files         777      777           
  Lines       91626    91632    +6     
=======================================
+ Hits        27804    27810    +6     
  Misses      63822    63822           
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch.py 93.45% <100.00%> (ø)
kubernetes_asyncio/watch/watch_test.py 97.22% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b270d...7d86e52. Read the comment docs.

@athornton
Copy link

Thank you! I have verified that applying the partial-application trick now works in kubernetes_asyncio-based kubespawner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watches still deserialize with _preload_content=False
2 participants