Simultaneously watch multiple event streams without threads. #13
Conversation
examples/example4.py
Outdated
| @@ -0,0 +1,38 @@ | |||
| """Watch multiple K8s event streams without threads.""" | |||
| import asyncio | |||
| from kubernetes_asyncio import client, config, watch | |||
There was a problem hiding this comment.
Travis is configured to run tests and check style of code. I know it's crazy... but he complains about a missing blank line here - between standard imports and local/library imports. Can you add this ?
Logs https://travis-ci.org/tomplus/kubernetes_asyncio/jobs/389560197
Status is presented on PR page and it's checked on every commit.
There was a problem hiding this comment.
I actually ran flake8 before I submitted the PR and it passed :)
I now see this repo uses custom scripts to enforce the style checks. Do you know why?
There was a problem hiding this comment.
I copied all scripts from the official python client (https://github.com/kubernetes-client/python) to make it as similar as possible to it.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 14 14
Lines 898 898
=======================================
Hits 831 831
Misses 67 67Continue to review full report at Codecov.
|
0ca7918 to
1e8ff61
Compare
|
Thank you. |
This PR demonstrates the use case I am most interested in. I know it is a simple extension of your example2, but this use case would be a lot less elegant with the original
kuberneteslibrary. Maybe you want to add it.