Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ssl_context= keyword raises DeprecationWarnings #59

Closed
mrocklin opened this issue Feb 1, 2019 · 10 comments
Closed

Use of ssl_context= keyword raises DeprecationWarnings #59

mrocklin opened this issue Feb 1, 2019 · 10 comments

Comments

@mrocklin
Copy link

mrocklin commented Feb 1, 2019

I get the following deprecation warning when using this library.

lib/python3.6/site-packages/kubernetes_asyncio/client/rest.py:73: DeprecationWarning: ssl_context is deprecated, use ssl=context instead
    ssl_context=ssl_context

Swapping out ssl_context= for ssl= works fine when I apply the change locally. However I'm not sure how best to enact change in this repository, given that parts (all?) of it is generated.

cc @yuvipanda

@tomplus
Copy link
Owner

tomplus commented Feb 1, 2019

Yes, this part is generated by swagger-codegen. Now I'm working on switching to the openapi-generator (#58). It's fixed there in the beta release so this warning will be removed eventually.

@tomplus
Copy link
Owner

tomplus commented Mar 24, 2019

It's been fixed in the version v9.0.0.

@tomplus tomplus closed this as completed Mar 24, 2019
@mrocklin
Copy link
Author

mrocklin commented Mar 24, 2019 via email

@mickours
Copy link
Contributor

mickours commented Feb 6, 2020

The problem is still present in the current version (10.0.1):

kubernetes_asyncio/client/rest.py:69: DeprecationWarning: ssl_context is deprecated, use ssl=context instead
    ssl_context=ssl_context

@tomplus
Copy link
Owner

tomplus commented Feb 6, 2020

@mickours could you check the version of aiohttp? The latest version of the library can print such warnings: #87 Thanks.

@mickours
Copy link
Contributor

mickours commented Feb 6, 2020

Thanks for the quick answer!

I'm using aiohttp 3.5.4

It seems to come from this line:
https://github.com/tomplus/kubernetes_asyncio/blob/master/kubernetes_asyncio/client/rest.py#L69

@tomplus
Copy link
Owner

tomplus commented Feb 6, 2020

Thanks, confirmed, reopen the issue.

@tomplus tomplus reopened this Feb 6, 2020
@tomplus
Copy link
Owner

tomplus commented Feb 26, 2020

It's fixed in the latest version of the library.

@tomplus tomplus closed this as completed Feb 26, 2020
@mrocklin
Copy link
Author

I'm glad to hear it! Thank you for tracking this @tomplus .

@mickours
Copy link
Contributor

Thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants