Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Provide initial mkdocs setup for new docs.promitor.io (🏗️) #1904

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

smholvoet
Copy link
Contributor

Related to #540

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 22, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2021

CLA assistant check
All committers have signed the CLA.

@tomkerkhove tomkerkhove changed the title 🛠️ mkdocs initial setup chore: 🛠️ mkdocs initial setup Dec 22, 2021
@tomkerkhove
Copy link
Owner

Feel free to change netlify.toml to use Mkdocs https://docs.netlify.com/configure-builds/common-configurations/#mkdocs

@tomkerkhove tomkerkhove changed the title chore: 🛠️ mkdocs initial setup chore: Provide initial mkdocs setup for new docs.promitor.io (🏗️) Dec 22, 2021
@tomkerkhove
Copy link
Owner

Happy new year! Just checking in to see if I can help you with anything or if you prefer me to take over?

@tomkerkhove
Copy link
Owner

Any thoughts on this @smholvoet?

@smholvoet
Copy link
Contributor Author

@tomkerkhove

Hi, been a while. So how would you want me to proceed? Start with updating netlify.toml first?

@tomkerkhove
Copy link
Owner

I'd rather ask you - If you say this current state is a good boilerplate and just needs content migration, then I think I can pick that up. The only thing I'd love to have is some help on the Netlify configuration and/or some docs on how to run it locally.

Does that sound reasonable?

@smholvoet
Copy link
Contributor Author

Sounds good. Don't have any experience with Netlify but I'll see what I can do.

Regarding running the docs locally, I'll add a dedicated page for that so it's easier for docs contributors to test out their changes. In case you want to try things out, here's a short summary:

  1. Install Python:

    choco install python
    
  2. Install mkdocs and related packages from a requirements.txt file (this gets added to the root of the repo) which would look like this:

    requirements.txt:

    mkdocs-material
    openpyxl
    

    Install all Python packages mentioned in the above file:

    pip install -r requirements.txt
    

    The above command will install (see this link for more info):

    • MkDocs
    • Markdown
    • Pygments
    • Python Markdown Extensions
    • 3rd-party plugins
  3. Run the docs locally"

@tomkerkhove
Copy link
Owner

That would be nice, thank you!

If you don't have experience with Netlify then I'll take a look at it - No worries!

@tomkerkhove tomkerkhove changed the base branch from master to docs-vnext February 20, 2022 20:42
@tomkerkhove
Copy link
Owner

Merging to temp branch to setup netlify - Feel free to PR the docs in there.

Thank you!

@tomkerkhove tomkerkhove marked this pull request as ready for review February 20, 2022 20:42
@tomkerkhove tomkerkhove self-requested a review as a code owner February 20, 2022 20:42
@tomkerkhove tomkerkhove merged commit 74b07ed into tomkerkhove:docs-vnext Feb 20, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Feb 20, 2022
tomkerkhove added a commit that referenced this pull request Apr 7, 2022
* chore: Provide initial mkdocs setup for new docs.promitor.io (🏗️) (#1904)

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Create netlify.toml

* Create requirements.txt

* Update netlify.toml

* Create mkdocs.yml

* Create README

* Rename README to README.md

* Update README

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Reshuffle

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Reshuffle more

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Config change

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Update netlify.toml

* Update netlify.toml

* Use strict processing

https://www.mkdocs.org/user-guide/configuration/#strict

* Remove nav for unexisting file

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* File does not exist

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix warnings

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Add link to alpha version

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix Markdown linting

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Co-authored-by: Sander Holvoet <holvoetsander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants