Giving more flexibility with the filter by tags

[locmai]

Component: Resource Discovery Group

We would love to have the ability to filter by tags that have the same key but with multiple values. For an example, right now we could only define the resource discovery like this:

resourceDiscoveryGroups:
- name: filtered-logic-apps-landscape
  type: LogicApp
  criteria:
    include:
      subscriptions:
      - SUBSCRIPTON-ID-ABC
      resourceGroups:
      - promitor-resource-group-1
      tags:
        app: promitor

So if we had many LogicApp with the tag app and we just want some of them, we couldn't do it for now.

Some initial approaches I could think of:

Approach 1:
For now we have these lines explicitly define the condition == :

promitor/src/Promitor.Agents.ResourceDiscovery/Graph/Query/GraphQueryBuilder.cs

Line 160 in e1fdb94

_queryBuilder.Append($"tags['{dictionaryEntry.Key}'] == '{dictionaryEntry.Value}' or ");

promitor/src/Promitor.Agents.ResourceDiscovery/Graph/Query/GraphQueryBuilder.cs

Line 164 in e1fdb94

_queryBuilder.AppendLine($"tags['{lastDictionaryEntry.Key}'] == '{lastDictionaryEntry.Value}'");

So my naive thought is changing that to =~ for regular expression match, and the configuration would be like this:

      tags:
        app: promitor|argocd

Approach 2:
Re-use the FilterByField the same way as other filter like subscriptions/resource groups:

promitor/src/Promitor.Agents.ResourceDiscovery/Graph/Query/GraphQueryBuilder.cs

Line 143 in e1fdb94

private void FilterByField(string fieldName, List<string> allowedValues)

And the tags would define in list:

      tags:
        app: 
        - promitor
        - argocd

This one will break the current setting since it takes a list instead of a string value, we could consider to handle both cases too make it backward compatible.

I could take this work / make changes and test but before that we would love some inputs or if there was another way to achieve our goal without making these changes.

[locmai]

Also one more feature we are thinking of is the filter by name with regex matching as well.

[locmai]

Update: I misunderstood the =~ in Azure graph query was for case sensitive. I'm trying the second approach now.

[locmai]

There's actually a regex thing for this, I'm exploring a bit more :D

az graph query -q "Resources | where tags['app'] matches regex @'promitor|argocd'" --output table

[locmai]

#1780 a naive attemp

[tomkerkhove]

Sorry for the delay, I will have a look at it asap!

[tomkerkhove]

And it's a fair request!

[tomkerkhove]

Created #1793