Added comment to explain change for race condition reported in #558

tomerfiliba-org · Sep 25, 2024 · 1c4c978 · 1c4c978
1 parent 879cbdc
commit 1c4c978
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rpyc/core/protocol.py b/rpyc/core/protocol.py
@@ -336,7 +336,7 @@ def _unbox(self, package):  # boxing
             return self._local_objects[value]
         if label == consts.LABEL_REMOTE_REF:
             id_pack = (str(value[0]), value[1], value[2])  # so value is a id_pack
-            proxy = self._proxy_cache.get(id_pack)
+            proxy = self._proxy_cache.get(id_pack)  # Ensure referents exist until we increment refcount issue #558
             if proxy is not None:
                 proxy.____refcount__ += 1  # if cached then remote incremented refcount, so sync refcount
             else: