Test against ember-data ^3.8.0 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b2e0b4 to
840112b
Compare
1852807 to
6b9ae92
Compare
6b9ae92 to
e690de9
Compare
3a0e50d to
00631b2
Compare
00631b2 to
f8a2a7d
Compare
|
I had another PR sometime before, which test against ember-cli generated new app. #200 |
da20639 to
738ef5f
Compare
rwjblue
reviewed
Apr 10, 2019
lib/utilities/pristine.js
Outdated
| @@ -95,7 +95,7 @@ function installPristineApp(appName, options) { | |||
| hasBowerComponents, | |||
| skipNpm, | |||
| emberVersion: options.emberVersion || 'canary', | |||
| emberDataVersion: options.emberDataVersion || 'emberjs/data#master' | |||
| emberDataVersion: options.emberDataVersion || 'emberjs/data#v3.8.0' | |||
There was a problem hiding this comment.
Can we use:
Suggested change
| emberDataVersion: options.emberDataVersion || 'emberjs/data#v3.8.0' | |
| emberDataVersion: options.emberDataVersion || '^3.8.0' |
I'd rather allow drift (using the latest tag)...
|
@kiwiupover Yea it is. I removed the canary-test (ember data master) and is now using the tests/dummy. The 30 file change was adding a new test/canary-app |
0f406ee to
a2899fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-fastboot/ember-cli-fastboot#679
ember-cli-addon-testby default tests againstember-data#masterthis PR removes#masterand uses^3.8.0Updates ember-cli to
3.8.0ember-engines/ember-engines#638