subcriber: update docs for EnvFilter Builder #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The from_env and try_from_env method on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior.
hawkw
approved these changes
Oct 30, 2023
davidbarsky
pushed a commit
that referenced
this pull request
Nov 7, 2023
The `from_env` and `try_from_env` methods on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior. ## Motivation Make the docs more clear, so that users need not look at the source to understand the difference between these two functions. ## Solution Updated the docs Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Nov 7, 2023
The `from_env` and `try_from_env` methods on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior. ## Motivation Make the docs more clear, so that users need not look at the source to understand the difference between these two functions. ## Solution Updated the docs Co-authored-by: Eliza Weisman <eliza@buoyant.io>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Nov 21, 2023
The `from_env` and `try_from_env` methods on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior. ## Motivation Make the docs more clear, so that users need not look at the source to understand the difference between these two functions. ## Solution Updated the docs Co-authored-by: Eliza Weisman <eliza@buoyant.io>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Feb 14, 2024
The `from_env` and `try_from_env` methods on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior. ## Motivation Make the docs more clear, so that users need not look at the source to understand the difference between these two functions. ## Solution Updated the docs Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The from_env and try_from_env method on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior.
Motivation
Make the docs more clear, so that users need not look at the source to understand the difference between these two functions.
Solution
Updated the docs