-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured Tracing Serialization/Deserialization #2113
Closed
Closed
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c06f9ab
Progress
jamesmunns 6fbb36b
Uh oh, painted into a corner.
jamesmunns eb82795
Aha! Use &'a Arguments<'a> instead
jamesmunns cd06215
Compiles, but not quite right yet
jamesmunns 6ff72b1
Fix serialization
jamesmunns 9d9eb65
Reorganize to match original ordering
jamesmunns e58f521
Adjust types
jamesmunns 33c94fb
Restore warnings
jamesmunns c10d98c
cargo-fmt
jamesmunns 27cd0b4
Merge branch 'master' into serde-structs
jamesmunns 2ab52c6
Replace `tracing-serde` with `tracing-serde-structs`.
jamesmunns 5137ade
Remove from cargo toml
jamesmunns 21ec350
Fix Cargo toml
jamesmunns a50d8a7
Increment MSRV
jamesmunns e22b091
Bump version check for tracing-serde
jamesmunns 5199e9b
Remove counting visitor, expose methods for length
jamesmunns 40d15a8
Apply review suggestions
jamesmunns ba2d5c9
Add to_owned() to everything, introduce CowString
jamesmunns 80c653b
Static Serialize* structures should be Send.
jamesmunns e0ad1f8
head down to the pub
azdle bd4dde6
Merge pull request #1 from azdle/wait-for-this-all-to-blow-over
jamesmunns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hawkw let me know if you want me to roll this into the next item to save CI time. Technically, it does build just fine on 1.51 tho, if you want to keep those separate (probably doesn't matter for v0.2 release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Either way, I should fix the copy/paste error in the comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, i would really prefer not to do a global MSRV bump, since
tracing
/tracing-core
are dependencies oftokio
, and i don't want to have to bump tokio's MSRV. having separate MSRVs for non-core crates is annoying, but it's probably preferable --- esp. since we would want to backport thetracing-serde
changes to v0.1.x.this is part of why i think it's probably a good idea to eventually move all of the non-core crates (such as
tracing-serde
) into their own repos...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, to pull in
heapless
, we need 1.51. I could write my own collection types on top of a fixed size array (or use an older version of heapless I guess?) but it'd have relatively low value. You know your MSRV guarantees better than me tho.