Implement event! and span! as proc macros #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ralith - is this Draft PR abandoned? Should we close it? |
|
Yes, I think the consensus is (quite sensibly) that we don't want to force syn on downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimally invasive refactoring of the core macros to make room for future expansions of the syntax such as #83. Fixes #133.
I've made only a token effort to identify and delete dead macro_rules macros so far, and I'm uncertain of the correctness of the transcribed macroexpansions, though the tests pass.
We probably want to convert more macros than just these two, as well.
Due to a fixed rustc bug, this requires a very recent nightly.