Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix rendering issue with misaligned tooltips #1430

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

davidbarsky
Copy link
Member

This branch resolves an issue where tooltips would render over the block's content. I resolved this issue by removing the usage of rustdoc's tooltip icons, whose styling isn't meant to be stable.

Before:
Before

After:
After

@davidbarsky davidbarsky requested review from carllerche, hawkw and a team as code owners June 9, 2021 21:57
@davidbarsky davidbarsky changed the title docs: Fix rendering issue with misaligned tooltips. docs: Fix rendering issue with misaligned tooltips Jun 9, 2021
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

let's backport this to 0.1.x as well, once it's merged?

@hawkw hawkw merged commit 3ddf54f into master Jun 10, 2021
@hawkw hawkw deleted the davidbarsky/fix-tooltip-rendering branch June 10, 2021 19:28
@davidbarsky
Copy link
Member Author

Didn't see this your comment or realize this was merged! Yeah, I'll open a backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants