Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing-flame: add module_path and file_and_line into Config #1134

Merged
merged 4 commits into from
Dec 14, 2020
Merged

tracing-flame: add module_path and file_and_line into Config #1134

merged 4 commits into from
Dec 14, 2020

Conversation

xiaopengli89
Copy link
Contributor

We should allow config whether or not display module_path or file/line in output.

@xiaopengli89 xiaopengli89 requested review from yaahc and a team as code owners December 11, 2020 11:16
yaahc
yaahc reviewed Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just want to correct some grammar in the doc comments

tracing-flame/src/lib.rs Outdated Show resolved Hide resolved
tracing-flame/src/lib.rs Outdated Show resolved Hide resolved
yaahc
yaahc approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@yaahc yaahc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much ^_^

hawkw
hawkw approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

tracing-flame/src/lib.rs Outdated Show resolved Hide resolved
@hawkw hawkw merged commit 27b2877 into tokio-rs:master Dec 14, 2020
hawkw added a commit that referenced this pull request Dec 14, 2020
@xiaopengli89 @yaahc @hawkw
tracing-flame: add module_path and file_and_line configs (#1134)
4c7b309 
We should allow configuring whether or not to display module_path
or file/line in output.

Co-authored-by: 李小鹏 <lixiaopeng.jetspark@bytedance.com>
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw mentioned this pull request Dec 14, 2020
Merged
hawkw added a commit that referenced this pull request Dec 14, 2020
@xiaopengli89 @yaahc @hawkw
tracing-flame: add module_path and file_and_line configs (#1134)
e904a05 
We should allow configuring whether or not to display module_path
or file/line in output.

Co-authored-by: 李小鹏 <lixiaopeng.jetspark@bytedance.com>
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@yaahc yaahc yaahc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaopengli89 @yaahc @hawkw