Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: make Compact event formatter not terrible #1068

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Oct 24, 2020

Depends on #1067

Motivation

Currently, the Compact event formatter in tracing-subscriber
is...kind of bad, and nobody seems to use it. It outputs the names of
all the spans in the current context, and (inexplicably) the names of
all the fields on the current span, but not their values. This isn't
very useful.

Solution

This branch rewrites the Compact formatter to be a little less bad.
Now, we output all the fields from the current span context, but skip
span names, and we shorten the level to a single character when it's
enabled. Additionally, using the compact formatter disables targets by
default. Now, the lines are nicely short, but maybe still useful.

Example output before this change:
Screenshot_20201024_122857
...and after:
Screenshot_20201024_133352

@hawkw hawkw requested a review from a team as a code owner October 24, 2020 20:56
@hawkw hawkw force-pushed the eliza/good-compact branch from f624fb2 to 8d003f2 Compare October 24, 2020 21:06
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw force-pushed the eliza/good-compact branch from 8d003f2 to 0973f25 Compare October 24, 2020 21:45
hawkw added 3 commits October 26, 2020 10:11
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw merged commit 5cb51e1 into eliza/futch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants