-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry to 0.28 #193
Conversation
Thanks for working on this! Can you add a commit that bumps the MSRV for this project to 1.75 in both CI and the Cargo metadata? |
Sorry, and also, a commit that bumps the version number? |
Sure, you're welcome. 😄 |
Damit, i just finished my PR aswell :D Thank you! |
Wow, just did the same. lol. I'll close mine too. |
Did you run into the error that I ran into while doing my PR?
Edit: After further debugging, it seems to be related to some of my own configuration, unrelated to the changes in tracing-opentelemetry/opentelementry-rust. |
|
||
[features] | ||
default = ["tracing-log", "metrics"] | ||
# Enables support for exporting OpenTelemetry metrics | ||
metrics = ["opentelemetry/metrics","opentelemetry_sdk/metrics", "smallvec"] | ||
# Enables experimental support for OpenTelemetry gauge metrics | ||
metrics_gauge_unstable = ["opentelemetry/otel_unstable"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This feature was necessary with opentelemetry 0.22, still in use when #129 was merged, but already obsolete with opentelemetry 0.23, so that it was not actually necessary in any tracing-opentelemetry release.
Thanks!
|
No description provided.