Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry to 0.28 #193

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Update opentelemetry to 0.28 #193

merged 3 commits into from
Feb 12, 2025

Conversation

cschramm
Copy link
Contributor

No description provided.

@djc
Copy link
Collaborator

djc commented Feb 11, 2025

Thanks for working on this!

Can you add a commit that bumps the MSRV for this project to 1.75 in both CI and the Cargo metadata?

@djc
Copy link
Collaborator

djc commented Feb 11, 2025

Sorry, and also, a commit that bumps the version number?

@cschramm
Copy link
Contributor Author

Sure, you're welcome. 😄

@turulix
Copy link

turulix commented Feb 11, 2025

Damit, i just finished my PR aswell :D Thank you!

@BSteffaniak
Copy link

Wow, just did the same. lol. I'll close mine too.

@BSteffaniak
Copy link

BSteffaniak commented Feb 11, 2025

Did you run into the error that I ran into while doing my PR?

There is an issue with the SdkMeterProvider not properly shutting down. The root of the error I was able to see said this: Status { code: Unimplemented, message: "unknown service opentelemetry.proto.collector.metrics.v1.MetricsService", metadata: MetadataMap { headers: {"content-type": "application/grpc"} }, source: None }. I am not super knowledgeable around this area, so I'm not sure what exactly needs to be fixed here, BUT, it seems to also happen with the basic-oltp example itself, so it seems like the error is likely out of scope of this repo. I'm going to open an issue there for that error and maybe we can get that figured out too.

Edit: After further debugging, it seems to be related to some of my own configuration, unrelated to the changes in tracing-opentelemetry/opentelementry-rust.


[features]
default = ["tracing-log", "metrics"]
# Enables support for exporting OpenTelemetry metrics
metrics = ["opentelemetry/metrics","opentelemetry_sdk/metrics", "smallvec"]
# Enables experimental support for OpenTelemetry gauge metrics
metrics_gauge_unstable = ["opentelemetry/otel_unstable"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This feature was necessary with opentelemetry 0.22, still in use when #129 was merged, but already obsolete with opentelemetry 0.23, so that it was not actually necessary in any tracing-opentelemetry release.

@djc djc merged commit a920559 into tokio-rs:v0.1.x Feb 12, 2025
14 checks passed
@djc
Copy link
Collaborator

djc commented Feb 12, 2025

Thanks!

  • Published tracing-opentelemetry v0.29.0 at registry crates-io
  • [new tag] v0.29.0 -> v0.29.0
  • Release notes

@cschramm cschramm deleted the otel-0.28 branch February 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants