Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: detect trailing whitespace #7013

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Dec 4, 2024

Trailing whitespace is generally always wrong. There are a few instances of it in the Tokio repository.

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Dec 4, 2024
@Darksonn Darksonn force-pushed the alice/detect-whitespace branch from 5849d20 to 5f9fd5f Compare December 4, 2024 15:09
@Darksonn Darksonn force-pushed the alice/detect-whitespace branch from 5f9fd5f to 22360c9 Compare December 4, 2024 15:18
@Darksonn
Copy link
Contributor Author

Darksonn commented Dec 4, 2024

Confirmed that it works:

./tokio/src/net/unix/stream.rs:    ///                     println!("read {} bytes", n);        
./tokio/src/task/join_set.rs:    ///     }   
./tokio/src/task/join_set.rs:    ///     let output = set.join_all().await;  
./tokio/src/task/join_set.rs:    ///     }   
./tokio/src/task/join_set.rs:    ///     
./tokio/src/runtime/task_hooks.rs:/// **Note**: This is an [unstable API][unstable]. The public API of this type  
./tokio/src/runtime/task_hooks.rs:/// may break in 1.x releases. See [the documentation on unstable  
./tokio/src/runtime/task_hooks.rs:/// features][unstable] for details.  
./tokio/src/runtime/task_hooks.rs:///  
./tokio/src/runtime/task_hooks.rs:/// [unstable]: crate#unstable-features  
./tokio/src/runtime/builder.rs:    /// **Note**: This is an [unstable API][unstable]. The public API of this type  
./tokio/src/runtime/builder.rs:    /// may break in 1.x releases. See [the documentation on unstable  
./tokio/src/runtime/builder.rs:    /// features][unstable] for details.  
./tokio/src/runtime/builder.rs:    ///  
./tokio/src/runtime/builder.rs:    /// [unstable]: crate#unstable-features  
./tokio/src/runtime/builder.rs:    /// **Note**: This is an [unstable API][unstable]. The public API of this type  
./tokio/src/runtime/builder.rs:    /// may break in 1.x releases. See [the documentation on unstable  
./tokio/src/runtime/builder.rs:    /// features][unstable] for details.  
./tokio/src/runtime/builder.rs:    ///  
./tokio/src/runtime/builder.rs:    /// [unstable]: crate#unstable-features  
./CONTRIBUTING.md:run loom tests that test unstable features. 
./CONTRIBUTING.md:if the command rejects a word, you should backtick the rejected word if it's code related. If not, the 
./CONTRIBUTING.md:rejected word should be put into `spellcheck.dic` file. 
./.github/buildomat/README.md:illumos 
./.circleci/config.yml:version: 2.1        
./tokio-util/src/task/spawn_pinned.rs:///     
./tokio-util/src/task/spawn_pinned.rs:///         }   

@Darksonn Darksonn merged commit c032ea0 into tokio-rs:master Dec 4, 2024
81 checks passed
@Darksonn Darksonn deleted the alice/detect-whitespace branch December 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants