Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated spin_loop_hint #3496

Closed
wants to merge 1 commit into from
Closed

Replace deprecated spin_loop_hint #3496

wants to merge 1 commit into from

Conversation

vorot93
Copy link
Member

@vorot93 vorot93 commented Feb 1, 2021

Tests throw warnings on nightly already.

@taiki-e
Copy link
Member

taiki-e commented Feb 1, 2021 •
edited
Loading

hint::spin_loop (alternative to spin_loop_hint) requires Rust 1.49+, so I would prefer to ignore deprecated warnings for now.

@vorot93
Copy link
Member Author

vorot93 commented Feb 1, 2021

Good catch. Given our MSRV policy, I suppose we'll have to wait until summer to merge this...

@vorot93 vorot93 added C-maintenance Category: PRs that clean code up or issues documenting cleanup. S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. labels Feb 1, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Feb 1, 2021

Maybe we should change this PR to add #[allow(deprecated)] annotations?

@vorot93 vorot93 mentioned this pull request Feb 1, 2021
Merged
@vorot93 vorot93 closed this Feb 1, 2021
@vorot93 vorot93 mentioned this pull request Feb 1, 2021
Closed
@vorot93 vorot93 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-maintenance Category: PRs that clean code up or issues documenting cleanup. S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vorot93 @taiki-e @Darksonn