-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: Add RwLock::{try_read, try_write} #2548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm — thanks for adding loom
tests!
n.b. that this change will conflict with #2445, which removes the ReleasingPermit
type — whichever PR merges second will need to be rebased and updated. I think this branch should probably merge first.
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Looks like master needs to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
I merged master, and it broke with the following message:
|
Closing due to inactivity. A new PR can be opened tracking master. |
Closes #2284