-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix a few broken links by using rustdoc #2400
Conversation
This is a deadlink, because `driver` mod is pub(crate).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
Any idea how to rephrase this
in https://docs.rs/tokio/0.2.18/tokio/time/struct.DelayQueue.html#implementation since according to git log 27e5b41067d01c0c9fac230c5addb58034201a63`
|
How about this? This leaves it a bit more ambiguous, but that's fine for now.
I also changed a sentence in the following paragraph that I thought was a bit awkward. |
Sounds good, though i'm still learning |
Just go for it. We can always change it later if someone thinks it should be changed. |
Can you merge Tokio's master branch? That should fix the FreeBSD ci. |
sure, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Do you have any other parts of the doc you want to change, or is this ready to merge?
In short In long |
Also, the link for
driver
is removed becausedriver
is nowpub(crate)
, so can't be used in docs.Motivation
Make doc's links more resistant.
Solution
Delagates doc's links resolution to
rustdoc
.Refs: #1473