Impl fs::remove_file #66
Conversation
4791734 to
9de63ad
Compare
|
Fixed the formatting and updated the PR. |
|
This seems to have a conflict with your other PR. |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
No flags provided here, as AT_REMOVEDIR is the only flag that is supported right now and we unlink a file here, so no need to specify this flag. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
9de63ad to
596e153
Compare
|
Do you rebase-merge this or squash-merge? |
|
It would get squashed. |
|
Okay, that's sad, because it effectively destroys history and replicability. |
|
All commits include the id of the PR, so you can view the history on the PR. |
|
Still you destroy information. If I want to revert just one patch of a PR because it was faulty, I have to jump through hoops to get that one patch and then revert it! Also, attribution is basically destroyed because the commit message is rewritten completely (which means trailers are removed, so attribution is gone)! I don't know whether you rewrote the commit message by hand or whether github just "did its thing here", either way it destroyed history without providing any benefit over a simple solid merge commit. |
|
If you want to continue this discussion, feel free to jump on our discord. |
Rel: #48
Suggestions welcome 😆