fs: impl File::read_exact_at and File::write_all_at
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
requested changes
Aug 10, 2021
|
Just giving this a bump. I'm really interested in using the feature. |
d1997ae to
ba77bb8
Compare
Noah-Kennedy
requested changes
Apr 13, 2022
ba77bb8 to
4c2d774
Compare
Noah-Kennedy
approved these changes
Apr 14, 2022
jiangliu
reviewed
May 26, 2022
jiangliu
reviewed
May 26, 2022
4c2d774 to
0c919b3
Compare
bnoordhuis
reviewed
Oct 14, 2022
littledivy
approved these changes
Oct 14, 2022
Noah-Kennedy
approved these changes
Oct 17, 2022
|
@songzhi can you resolve the conflicts? I'll merge once that's done. |
Current API and abstractions make it possible to write these helper methods.
0c919b3 to
2df1fa6
Compare
Noah-Kennedy
approved these changes
Oct 22, 2022
FrankReh
approved these changes
Oct 28, 2022
|
@carllerche Waiting for your okay. You had requested changes so the page wants your blessing. |
|
If @Noah-Kennedy and @carllerche say okay (actually I think Noah did already) we just need the branch rebased from master. Does the OP want to do that or would they like me to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current API and abstractions make it possible to write these helper methods.
Fixes #41