op: fix 'already borrowed' panic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When failing to submit operation to kernel, an "already borrowed" panic can happen. This ensures the `RefCel` borrow guard is dropped before dropping resources.
songzhi
reviewed
Aug 3, 2021
| let mut inner = inner_rc.borrow_mut(); | ||
| let inner = &mut *inner; | ||
| let mut inner_ref = inner_rc.borrow_mut(); | ||
| let inner = &mut *inner_ref; | ||
|
|
||
| // If the submission queue is full, flush it to the kernel | ||
| if inner.uring.submission().is_full() { |
There was a problem hiding this comment.
inner.submit()?; at line 70.
Doesn't it meet the same problem?
There was a problem hiding this comment.
It shouldn't because the Op instance hasn't been created yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When failing to submit operation to kernel, an "already borrowed" panic
can happen. This ensures the
RefCelborrow guard is dropped beforedropping resources.
Fixes #35