Expose buf_index
#187
Merged
Expose buf_index
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
I don't see a reason why the buffer index should not be publicly accessible.
In a future change to resolve #185 and enable other alternative fixed buffer collections, this method will be provided by a trait, which should be made public to enable off-crate implementations.
FrankReh
approved these changes
Nov 30, 2022
|
Looks like fmt is not happy. Maybe a space or tab left on that blank line above the doc comment? |
FrankReh
requested changes
Nov 30, 2022
FrankReh
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to build abstractions on top of the
FixedBufferRegistry. I can work around this not being exposed it but it's a bit unnecessary to track the same information in multiple places and I don't see a reason from hiding this information from the users in the first place.