Move edition to 2021 #688
Merged
Move edition to 2021 #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like since I've last looked at the repo, the update to MSRV 1.56 happened, and we don't have any clippy errors on the 2021 edition, so I _think_ we can just up this value now. Closes tokio-rs#553
This was introduced in [Rust 1.56](https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#cargo-rust-version) so we can set this explicitly here. This means that folks that happen to have an older rust version set don't run into abstruse compiler errors.
|
no problem, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like since I've last looked at the repo the update to
MSRV 1.56 happened and we don't have any clippy errors on the 2021
edition. Therefore, I think we can just up the edition now.
If there's a good reason not to do so let me know and I can close this.
I've also set the MSRV explicitly in the Cargo.toml so that users that happen to have an older rust version set (like I did when I was testing 1.51 at some point) get an error telling them they're on the wrong version instead of abstruse compiler errors.
Closes #553, also closes #595 since 1.51 will no longer be supported.