New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider placing `Config::format` behind a feature flag. #1021

Closed

gibbz00 opened this issue Mar 30, 2024 · 0 comments · Fixed by #1022

Contributor

gibbz00 commented Mar 30, 2024 •

edited

Loading

prost/prost-build/src/lib.rs

Lines 940 to 944 in 50bab4f

    
               /// Configures the code generator to format the output code via `prettyplease`. 
        
               /// 
        
               /// By default, this is enabled but if the `format` feature is not enabled this does 
        
               /// nothing. 
        
               pub fn format(&mut self, enabled: bool) -> &mut Self {

Think it is better to create a compile time error when someone is trying to enable/disable formatting when it isn't enabled.

gibbz00 added a commit to gibbz00/prost that referenced this issue


          fix: tokio-rs#1021

8fdf9f6

gibbz00 mentioned this issue

Place Config::format behind the format feature flag. #1022

Merged

gibbz00 added a commit to gibbz00/prost that referenced this issue


          fix: tokio-rs#1021

3a5a63c

gibbz00 added a commit to gibbz00/prost that referenced this issue


          fix: tokio-rs#1021

3a1444e

github-merge-queue bot pushed a commit that referenced this issue


          fix: #1021 (#1022)

ee96a04

caspermeijn closed this as completed in #1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment