chore(CI): don't trigger duplicate CI runs on pushes #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CI is configured to run on all pushes, and on all pull requests. This means that when changes are pushed to a PR, the CI jobs run *twice*. That's not great, as it means our builds take a bit longer. This branch fixes the CI configuration, so that CI jobs are triggered on all pull requests, and on pushes to `main`, rather than on all pushes. Now, all jobs should only run a single time for every push to a PR.
seanmonstar
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CI is configured to run on all pushes, and on all pull
requests. This means that when changes are pushed to a PR, the CI jobs
run twice. That's not great, as it means our builds take a bit longer.
For example:
This branch fixes the CI configuration, so that CI jobs are triggered on
all pull requests, and on pushes to
main, rather than on all pushes.Now, all jobs should only run a single time for every push to a PR.