Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axum: Move serve.rs to serve/mod.rs #3161

Merged
merged 1 commit into from
Jan 8, 2025
Merged

axum: Move serve.rs to serve/mod.rs #3161

merged 1 commit into from
Jan 8, 2025

Conversation

mladedav
Copy link
Collaborator

@mladedav mladedav commented Jan 8, 2025

Motivation

We use pretty consistently x/mod.rs insteadd of x.rs when there is the directory. When we added the serve directory, the serve.rs file wasn't moved.

Solution

Move the file.

jplatte
jplatte approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try enabling the self_named_module_files clippy lint. Can be a separate PR.

@mladedav mladedav merged commit 18a99da into main Jan 8, 2025
18 checks passed
@mladedav mladedav deleted the dm/move-serve branch January 8, 2025 16:56
@mladedav mladedav mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mladedav @jplatte