Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Comment with context
We are currently using
ubuntu-latest
runners which may change and usually do change every two years. This can lead to issues as in #2994 where caches can be reused in a different version of ubuntu which can then break linking.Solution
We set the runner version explicitly. This does not prevent similar issue as in the linked PR, but it will happen in the PR that upgrades the runner instead of random other PR that happened to run actions after the change.
I've also included the
ubuntu-24.04
string in the cache key so that the issue doesn't happen again. This makes migration harder because this should be changed when a runner changes and I have not found a good way to deduplicate this because of this issue. But if both strings are correct, we will never use cache with objects built with older libraries.