Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include variable's "codeSyntax" property in exported token json #28

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

patrick-lienau
Copy link
Contributor

@patrick-lienau patrick-lienau commented Oct 20, 2024

My team found that while your plugin was a good fit for our use case, generating scss variables. Later however, we realized that depending on how our variables were organized (hierarchically) we could end up with Dev Mode showing us variable names like var(--Brand-Midnight-Blue-Midnight-Blue-400) that's obviously a little too verbose.

We found that we can assign the "code syntax" for a given variable which allowed us to customize the variable in the outputted css shown in Dev Mode.

image
Unfortunately, your plugin does not support "code syntax" at the moment. Since your project is open source, I thought I would make a quick PR. It's a really simple implementation but I'll allow us to make full use of your plugin. Thanks!

image

@PavelLaptev PavelLaptev merged commit 0fecf27 into tokens-bruecke:main Dec 30, 2024
@PavelLaptev
Copy link
Collaborator

PavelLaptev commented Dec 30, 2024

@patrick-lienau This is cool, thank you for your contribution!
Sorry the approval took me so long :-)

The new plugin version is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants