Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right the heuristic wrongs #20

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

JeroenRoodIHS
Copy link
Contributor

Support naming conventions of any casing, and be indiscriminate on separators (currently supporting: "-", "_" and ".").

Please refer to my comment for the reasoning behind this PR (my apologies):
#18 (comment)

Support naming conventions of any casing, and be indiscriminate on separators (currently supporting: "-", "_" and ".").
@JeroenRoodIHS
Copy link
Contributor Author

I noticed a merge conflict due to upstream changes. Fixed the conflict.

@JeroenRoodIHS
Copy link
Contributor Author

Hi @PavelLaptev, there is an issue with specific font weight names. An example is Noto Sans, from Google Fonts. In Figma, the font weight 600 is defined as SemiBold. Because the earlier code does not work case-insensitive, this one is missed. Hence, you end up with 400 for the font weight name SemiBold, rather than the desired 600. This PR would solve that issue. Is it possible to merge this?

@PavelLaptev
Copy link
Collaborator

@JeroenRoodIHS thank you for the PR! I'll publish the new version now :-)

@PavelLaptev PavelLaptev merged commit 0b21391 into tokens-bruecke:main Apr 15, 2024
@JeroenRoodIHS
Copy link
Contributor Author

@PavelLaptev I do realize that this issue of case-sensitivity was caused by my own sluggishness. Apologies for the inconvenience. A lesson learned by me: test, test and then test some more.

@PavelLaptev
Copy link
Collaborator

Thank and don't worry 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants