Missing Tofu Binary in Docker Image #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commit introduces logic to gracefully handle the case when the tofu binary is not found in the Docker image, improving the overall user experience. BREAKING CHANGE: The previous behavior of the application when the tofu binary was missing may have caused unexpected crashes. git commit -m "feat(tofu): add handling for missing tofu binary in Docker image This commit introduces logic to gracefully handle the case when the tofu binary is not found in the Docker image, improving the overall user experience. BREAKING CHANGE: The previous behavior of the application when the tofu binary was missing may have caused unexpected crashes."
kvendingoldo
approved these changes
Sep 25, 2024
|
LGTM! |
|
This PR is included in version 2.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with the tofuutils/pre-commit-opentofu Docker image. Currently, the image contains the tofu package as a ZIP file (tofu_1.6.1_linux_amd64.zip), but it does not include the extracted tofu binary, which prevents the command from running as expected.
Details:
Image Name: tofuutils/pre-commit-opentofu
ZIP File Location: /usr/bin/tofu_1.6.1_linux_amd64.zip
Missing Binary: The extracted tofu binary is not available in the expected path.
Secreenshot of zip tofu binary:
Suggested Solution:
Please consider updating the Docker image to include the extracted tofu binary instead of the ZIP file. This would allow users to run the tofu command without needing to manually extract the binary.