update parser id to clarify the identifier liked-type

tofu-soya · Apr 5, 2024 · 3441968 · 3441968
1 parent 9a2dda2
commit 3441968
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yl-ddd-ts",
-  "version": "1.0.4",
+  "version": "2.0.0",
   "description": "Node typescript seedwork",
   "main": "dist/src/index.js",
   "author": "tuancaurao <tuancr.pt@gmail.com>",

diff --git a/src/model/entity.base.ts b/src/model/entity.base.ts
@@ -75,7 +75,7 @@ const construct: EntityParserFactory<WithEntityMetaInput<unknown>> =
         }),
         Either.flatMap((metaLike) => {
           return structSummarizerParsing<Omit<EntityCommonProps, '_tag'>>({
-            id: parseId(options.autoGenId ? uuidv4() : metaLike.id),
+            id: parseId(options.autoGenId ? uuidv4() : metaLike.id || ''),
             createdAt: Either.right(metaLike.createdAt),
             updatedAt: Either.right(metaLike.updatedAt),
           });

diff --git a/src/model/entity.base.type.ts b/src/model/entity.base.type.ts
@@ -40,7 +40,7 @@ type RecursiveWithArray<I> = I extends Entity
         : Liken<I>;
 
 export type WithEntityMetaInput<OriginInput> = OriginInput &
-  Liken<Omit<EntityCommonProps, '_tag' | 'id'>> & { id?: unknown };
+  Liken<Omit<EntityCommonProps, '_tag' | 'id'>> & { id?: string };
 
 export type EntityInvariantParser<
   T extends Entity,

diff --git a/src/model/parser.ts b/src/model/parser.ts
@@ -143,8 +143,8 @@ export const structSummarizerParsing = <T>(struct: ParsingInput<T>) => {
 };
 
 export const arrayParser =
-  <T>(itemParser: Parser<T>) =>
-  (a: unknown[]) => {
+  <T, I>(itemParser: Parser<T, I>) =>
+  (a: I[]) => {
     return pipe(
       a,
       A.reduceWithIndex({}, (i, acc, cur) => ({

diff --git a/src/typeclasses/obj-with-id.ts b/src/typeclasses/obj-with-id.ts
@@ -8,7 +8,7 @@ import { v4 as uuidv4 } from 'uuid';
 
 export type Identifier = Brand<string, 'Identifier'>;
 
-export const parseId: Parser<Identifier> = (v: unknown) => {
+export const parseId: Parser<Identifier, string> = (v: string) => {
   const isId = (v: unknown): v is Identifier =>
     typeof v === 'string' && v.length > 0;
   return Either.fromPredicate(isId, () =>