Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blocks): add support for non consecutive list in adapter #8802

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Nov 26, 2024

This closes BS-1947

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:24am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:24am

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 9a6041f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fourdim fourdim marked this pull request as ready for review November 26, 2024 03:16
@fourdim fourdim requested a review from a team as a code owner November 26, 2024 03:16
Copy link
Contributor Author

fourdim commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a6041f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.08 MB (+0.01% 🔺)
@blocksuite/affine/block-std 156.59 KB (0%)
@blocksuite/affine/block-std/gfx 80.15 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.87 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.16 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.88 MB (-0.03% 🔽)
@blocksuite/affine/blocks 1.96 MB (-0.02% 🔽)
@blocksuite/affine/blocks/schemas 88.62 KB (0%)

@fourdim fourdim marked this pull request as draft November 26, 2024 03:21
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 0fe8416 to 7e8152a Compare November 26, 2024 03:37
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 7e8152a to 160abd7 Compare November 26, 2024 03:56
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 160abd7 to 2b7dec7 Compare November 26, 2024 03:59
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 2b7dec7 to 8b3ce8a Compare November 26, 2024 04:08
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 8b3ce8a to c0f75e0 Compare November 26, 2024 04:22
@fourdim fourdim marked this pull request as ready for review November 26, 2024 04:23
@fourdim fourdim added the dont merge Experimental pull requests label Nov 28, 2024
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from c0f75e0 to 73da914 Compare November 30, 2024 02:07
@fourdim fourdim changed the base branch from master to 11-22-refactor_markdown_adapter November 30, 2024 02:07
@fourdim fourdim removed the dont merge Experimental pull requests label Nov 30, 2024
@fourdim fourdim added the merge label Dec 3, 2024
Copy link
Contributor Author

fourdim commented Dec 3, 2024

Merge activity

  • Dec 2, 10:43 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 11:08 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 11:12 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 2, 11:12 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 4:12 AM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Dec 2, 11:17 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 11:22 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 11:27 PM EST: A user merged this pull request with the Graphite merge queue.

@doodlewind doodlewind changed the base branch from 11-22-refactor_markdown_adapter to graphite-base/8802 December 3, 2024 04:05
@graphite-app graphite-app bot changed the base branch from graphite-base/8802 to master December 3, 2024 04:11
@graphite-app graphite-app bot removed the merge label Dec 3, 2024
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 73da914 to 20d22f5 Compare December 3, 2024 04:16
@fourdim fourdim added the merge label Dec 3, 2024
@fourdim fourdim force-pushed the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch from 20d22f5 to 9a6041f Compare December 3, 2024 04:22
@graphite-app graphite-app bot merged commit 9a6041f into master Dec 3, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 11-25-feat_blocks_add_support_for_non_consecutive_list_in_adapter branch December 3, 2024 04:27
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants