Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support linux aarch64 #2251

Closed
wants to merge 6 commits into from
Closed

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 6, 2023

@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:53pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:53pm

@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@github-actions github-actions bot added the app:electron Related to electron app label May 6, 2023
@himself65 himself65 temporarily deployed to development May 6, 2023 22:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (1e8c5a4) 71.72% compared to head (5bd2d22) 71.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   71.72%   71.69%   -0.04%     
==========================================
  Files         296      296              
  Lines        6595     6595              
  Branches     1074     1074              
==========================================
- Hits         4730     4728       -2     
- Misses       1668     1670       +2     
  Partials      197      197              
Flag Coverage Δ
e2etest 69.25% <ø> (-0.05%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.14% <ø> (ø)
unittest 36.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 6, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 6, 2023 23:03 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 6, 2023 23:03 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5bd2d22
Status: ✅  Deploy successful!
Preview URL: https://8200ab45.affine.pages.dev
Branch Preview URL: https://himself65-0506-linux-arm64.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-preview May 6, 2023 23:07 Inactive
@perfsee
Copy link

perfsee bot commented May 6, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
< Bundle              3.11 MB        3.14 MB    +33.2 kB(+1.07%)   
< Initial JS          1.86 MB        1.87 MB    +11.2 kB(+0.60%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
< Bundle                 3 MB        3.02 MB    +23.8 kB(+0.79%)   
< Initial JS          1.75 MB        1.75 MB    +1.88 kB(+0.11%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 requested review from m1911star and pengx17 May 6, 2023 23:13
@himself65 himself65 marked this pull request as ready for review May 6, 2023 23:47
@himself65
Copy link
Contributor Author

image

Copy link
Contributor Author

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Cannot merge

@himself65 himself65 added the blocked PR is disallowed to merge due to some reasons label May 8, 2023
@himself65 himself65 marked this pull request as draft May 8, 2023 02:18
@pengx17
Copy link
Collaborator

pengx17 commented May 8, 2023

Cannot merge

Oh I believe the issue is that sqlite bindings may need to build against linux arm64 as well

@pengx17
Copy link
Collaborator

pengx17 commented May 8, 2023

electron/rebuild#378 Perhaps we need to follow some steps to configure node-gyp here

@himself65
Copy link
Contributor Author

I'm not good at this, please handle this PR if you have time

@himself65 himself65 temporarily deployed to development May 8, 2023 23:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:26 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:28 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 8, 2023 23:48 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 8, 2023 23:53 Inactive
@himself65
Copy link
Contributor Author

stale PR, closing for now

@himself65 himself65 closed this Aug 5, 2023
@Brooooooklyn Brooooooklyn deleted the himself65/0506-linux-arm64 branch November 29, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app blocked PR is disallowed to merge due to some reasons
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Release support for arm64 in Linux
3 participants