-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and push docker images with Github Actions #47
base: main
Are you sure you want to change the base?
Conversation
@@ -3,6 +3,7 @@ RUN apk update && apk upgrade && apk add sqlite-static | |||
WORKDIR /build/ | |||
ARG version | |||
RUN git clone --branch ${version:-dist} --depth 1 https://github.com/toddsundsted/ktistec . | |||
RUN shards update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, I got the error
#13 6.141 Outdated shard.lock (backtracer requirements changed). Please run shards update instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same error here as well without running shards update
first.
thanks! this is great! i'm reviewing it now. the only hold up is "shards update". i'd like dependencies to be fixed in a release—shards update changes them. it looks like, however, something happened to the backtracer shard. i'd like to address that specifically, if possible, rather just work around it with an update. |
d6e65f7
to
bcd4cad
Compare
I've removed the |
I'm realizing that my latest built docker image still doesn't have the latest code (so I'm still hitting #21), because the Dockerfile clones the
It seems to me like it would be more idiomatic to use |
bcd4cad
to
dcf1615
Compare
This will have Github Actions build and push docker images to
toddsundsted/ktistec:latest
every time you update themain
branch. If you'd like, I can make it push tags totoddsundsted/ktistec:<tagname>
instead / in addition.To make this work, you'll have to:
DOCKERHUB_USERNAME
andDOCKERHUB_TOKEN
secrets at https://github.com/toddsundsted/ktistec/settings/secrets/actions