Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit check for component definition #5

Closed
wants to merge 1 commit into from

Conversation

cary-smith
Copy link

We have a directive library that supports multiple AngularJS versions (1.3+). We would like to include your code without worrying about overwriting angular 1.5's implementation by accident when people upgrade their angular version.

We have a an directive library that supports multiple AngularJS versions (1.3+). We would like to include your code without worrying about overwriting angular 1.5's implementation by accident when people upgrade their angular version.
@toddmotto toddmotto closed this Jan 9, 2016
@toddmotto
Copy link
Owner

Added this manually (47d5dcc) in with another update in 0.0.2 release, easier as the gulp task wasn't run to generate necessary /dist files. Thanks for pointing this out and contributing!

@cary-smith
Copy link
Author

Thanks for adding it and thank you for making the library in the first
place! This allows us to upgrade the library ahead of the point we would
drop angular 1.4 support so we can get ready for 2. We were initially
cloning and modifying your code, this will make it far easier to use
wholesale.

Thanks again!

On Sat, Jan 9, 2016 at 11:09 AM, Todd Motto notifications@github.com
wrote:

Added this manually (47d5dcc
47d5dcc)
in with another update in 0.0.2 release, easier as the gulp task wasn't
run to generate necessary /dist files. Thanks for pointing this out and
contributing!


Reply to this email directly or view it on GitHub
#5 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants