This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Minor revamp #4
Merged
Minor revamp #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Exanlv
suggested changes
Mar 17, 2023
| { | ||
| return json_decode(file_get_contents(__DIR__ . "/../../tools/HttpExceptions/HttpCodes.json")); | ||
| return json_decode(file_get_contents(__DIR__ . "/../../tools/HttpExceptions/HttpCodes.json"), true); |
There was a problem hiding this comment.
Still using json instead of php to store the data
There was a problem hiding this comment.
Well this is just an example so I wouldn't worry too much about it 😅
There was a problem hiding this comment.
youre also using this json in other places, no?
There was a problem hiding this comment.
Just for generator stuff nothing else
| @@ -359,20 +359,20 @@ public static function run(EmitterInterface $emitter = null): void | |||
| } | |||
|
|
|||
| if ($resolved === null) { | |||
| if (!self::$emitHttpExceptions) { | |||
| if (!is_subclass_of($e, HttpException::class)) { | |||
There was a problem hiding this comment.
This is jank, just catch HttpExceptions seperately
There was a problem hiding this comment.
You mean just have Catchers?
There was a problem hiding this comment.
try {
// ...
} catch (HttpException $e) {
// ...
} catch (Exception $e) {
// ...
}There was a problem hiding this comment.
YOU CAN DO THAT!?!? I've been lied to my entire life
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.