This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Refactored Router to be a non-static class #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xHeaven
suggested changes
May 12, 2023
xHeaven
suggested changes
May 13, 2023
Examples are getting nuked and there's gonna be more changes which is why the README hasn't been updated |
xHeaven
approved these changes
May 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In attempts to make all of the libraries in TNAPF comply with PSR and be usable in any circumstance. It only makes sense to convert Router into a non-static class so it can be used with PSR-15. Which will be implemented soon