Fix format seperator #343

asyncmind0 · 2021-10-31T00:13:24Z

Rebase of

tony · 2021-10-31T02:08:59Z

@jagguli Thank you!

tony · 2021-10-31T02:09:50Z

@jagguli If you want a smoother rebase, you can do git pull --rebase origin master and git push --force-with-lease where origin is https://github.com/tmux-python/libtmux.git

CLAassistant · 2022-01-11T03:27:17Z

All committers have signed the CLA.

tony · 2022-02-22T12:33:11Z

@jagguli Sorry for the delay! You are welcome to do another rebase

Also does this have a dedicated bug issue documenting what the problem is? (This is a pretty systemic change!)

tony · 2022-02-22T12:33:28Z

libtmux/formats.py

@@ -7,6 +7,11 @@

 """

+from __future__ import absolute_import, unicode_literals, with_statement


It's safe to remove this line

libtmux/formats.py

libtmux/window.py

tony

#354 is on deck and may cause conflicts. Would like to get this in first if possible. Some minor comments made

codecov · 2022-02-26T16:21:00Z

Codecov Report

Merging #343 (666e4d2) into master (e7c53ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 666e4d2 differs from pull request most recent head 9411cc1. Consider uploading reports for the commit 9411cc1 to get more accurate results

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   87.80%   87.81%           
=======================================
  Files          15       15           
  Lines        1509     1510    +1     
=======================================
+ Hits         1325     1326    +1     
  Misses        184      184

Impacted Files	Coverage Δ
libtmux/formats.py	`100.00% <100.00%> (ø)`
libtmux/server.py	`79.19% <100.00%> (-0.12%)`	⬇️
libtmux/session.py	`81.54% <100.00%> (ø)`
libtmux/window.py	`84.33% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5458b98...9411cc1. Read the comment docs.

…ility with tmux 3.1 (#298) See also: #343

- for some reason on my arch install tmux does not print back tabs I'm not sure if it affects other but just puttin this out there

tony · 2022-02-26T16:56:19Z

libtmux/formats.py

@@ -6,6 +6,9 @@
 For reference: https://github.com/tmux/tmux/blob/master/format.c

 """
+import os
+
+FORMAT_SEPERATOR = os.environ.get("TMUX_SEPERATOR", "|")


Astonishingly, despite "seperator" being used everywhere (and it feels right to me) apparently its separator

I will make a change for that and also give it a namespaced env name LIBTMUX_TMUX_FORMAT_SEPARATOR to avoid any ambiguity

24393a3, 76faeb1

(side notes: FYI these refs are subject to break pending change #350)

P.S. I opened #355 to discuss a default formatting string

Introduced initially via #343 as TMUX_SEPERATOR but later renamed to LIBTMUX_TMUX_FORMAT_SEPARATOR.

tony · 2022-02-26T17:17:39Z

@jagguli This is now released on 0.11.0b0 for testing: pypi, git branch

The separator is configurable via LIBTMUX_TMUX_FORMAT_SEPRATOR. A discussion is at #355 for any issues the arise

tony · 2022-02-26T17:21:12Z

@jagguli Similar to the other PR, my bad for now staying on top of the pull request. I apologize for keeping it in a holding pattern so long

Shoot me an email next time you make a PR so it doesn't repeat itself. I am overwhelmed with notifications on GH

asyncmind0 mentioned this pull request Oct 31, 2021

fix: use | instead of \t for format sepatator #305

Closed

tmux-python deleted a comment from codecov bot Oct 31, 2021

tony reviewed Feb 22, 2022

View reviewed changes

libtmux/formats.py Outdated Show resolved Hide resolved

tony reviewed Feb 22, 2022

View reviewed changes

libtmux/window.py Outdated Show resolved Hide resolved

tony self-requested a review February 22, 2022 16:05

tony requested changes Feb 22, 2022

View reviewed changes

tony force-pushed the fix_format_seperator branch 4 times, most recently from a077881 to 9c1fe18 Compare February 26, 2022 16:29

tony pushed a commit that referenced this pull request Feb 26, 2022

compat: split on a special wildcard instead of tab to ensure compatib…

942ac7a

…ility with tmux 3.1 (#298) See also: #343

tony force-pushed the fix_format_seperator branch from 9c1fe18 to 9f67200 Compare February 26, 2022 16:43

asyncmind0 and others added 4 commits February 26, 2022 10:46

fix: use | instead of \t for format sepatator

51dbc12

- for some reason on my arch install tmux does not print back tabs I'm not sure if it affects other but just puttin this out there

Changed get seperator from env variable if available

cd918d5

chore(window.split_window): Move to f-string

fc235ba

chore(formats): Import tweak

9411cc1

tony force-pushed the fix_format_seperator branch from 9f67200 to 9411cc1 Compare February 26, 2022 16:46

tony merged commit b231346 into tmux-python:master Feb 26, 2022

tony reviewed Feb 26, 2022

View reviewed changes

tony added a commit that referenced this pull request Feb 26, 2022

docs(CHANGES): DOcument merge of #343

cf8d862

tony added a commit that referenced this pull request Feb 26, 2022

docs(api): Document LIBTMUX_TMUX_FORMAT_SEPARATOR

6354e8f

Introduced initially via #343 as TMUX_SEPERATOR but later renamed to LIBTMUX_TMUX_FORMAT_SEPARATOR.

tony added a commit that referenced this pull request Feb 26, 2022

docs(CHANGES): Document merge of #343

13258e8

tony added a commit that referenced this pull request Feb 26, 2022

docs(api): Document LIBTMUX_TMUX_FORMAT_SEPARATOR

42e91ec

Introduced initially via #343 as TMUX_SEPERATOR but later renamed to LIBTMUX_TMUX_FORMAT_SEPARATOR.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix format seperator #343

Fix format seperator #343

asyncmind0 commented Oct 31, 2021 •

edited

Loading

tony commented Oct 31, 2021

tony commented Oct 31, 2021

CLAassistant commented Jan 11, 2022 •

edited

Loading

tony commented Feb 22, 2022

tony Feb 22, 2022

tony left a comment

codecov bot commented Feb 26, 2022 •

edited

Loading

tony Feb 26, 2022

tony Feb 26, 2022 •

edited

Loading

tony Feb 26, 2022

tony commented Feb 26, 2022 •

edited

Loading

tony commented Feb 26, 2022

		@@ -7,6 +7,11 @@

		"""

		from __future__ import absolute_import, unicode_literals, with_statement

Fix format seperator #343

Fix format seperator #343

Conversation

asyncmind0 commented Oct 31, 2021 • edited Loading

tony commented Oct 31, 2021

tony commented Oct 31, 2021

CLAassistant commented Jan 11, 2022 • edited Loading

tony commented Feb 22, 2022

tony Feb 22, 2022

Choose a reason for hiding this comment

tony left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 26, 2022 • edited Loading

Codecov Report

tony Feb 26, 2022

Choose a reason for hiding this comment

tony Feb 26, 2022 • edited Loading

Choose a reason for hiding this comment

tony Feb 26, 2022

Choose a reason for hiding this comment

tony commented Feb 26, 2022 • edited Loading

tony commented Feb 26, 2022

asyncmind0 commented Oct 31, 2021 •

edited

Loading

CLAassistant commented Jan 11, 2022 •

edited

Loading

codecov bot commented Feb 26, 2022 •

edited

Loading

tony Feb 26, 2022 •

edited

Loading

tony commented Feb 26, 2022 •

edited

Loading