Fix sending multiple segment messages #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tmds
reviewed
Feb 14, 2023
| namespace Tmds.DBus.Protocol; | ||
|
|
||
| internal ref struct SignatureReader |
There was a problem hiding this comment.
This change is not related to the multi-segment send.
@affederaffe are you using this? Which member exactly?
There was a problem hiding this comment.
If you would like to have this type exposed, please make a separate PR, and only make the members you need public.
There was a problem hiding this comment.
I think I was using it for the source generator at some point, though I removed it since it creates an explicit dependency on Tmds.DBus.Protocol. Reverted the relevant commit.
tmds
reviewed
Feb 14, 2023
| @@ -94,7 +94,7 @@ private async void ReadMessagesIntoSocket() | |||
| SequencePosition position = buffer.Start; | |||
| while (buffer.TryGet(ref position, out ReadOnlyMemory<byte> memory)) | |||
| { | |||
| await _socket.SendAsync(buffer.First, handles).ConfigureAwait(false); | |||
| await _socket.SendAsync(memory, handles).ConfigureAwait(false); | |||
This reverts commit e86bcf1.
|
@affederaffe thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending non-single-segmented buffers, only the first segment was incorrectly sent over and over again.