Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rewire): remove rewire dep and related code, override process via #92

Merged
merged 1 commit into from
Jan 12, 2022
Merged

test(rewire): remove rewire dep and related code, override process via #92

merged 1 commit into from
Jan 12, 2022

Conversation

tmcgee123
Copy link
Owner

Object.assign instead

@tmcgee123 tmcgee123 requested a review from mlex January 11, 2022 23:43
@tmcgee123 tmcgee123 requested a review from hdavidzhu January 11, 2022 23:43
@tmcgee123
Copy link
Owner Author

I've added you both (@mlex @hdavidzhu as reviewers so I don't do something stupid on accident :) Feel free to merge once approved.

@tmcgee123 tmcgee123 added bug and removed enhancement labels Jan 12, 2022
hdavidzhu
hdavidzhu approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@hdavidzhu hdavidzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/index.spec.js Outdated Show resolved Hide resolved
@tmcgee123 tmcgee123 merged commit 264c733 into master Jan 12, 2022
@tmcgee123 tmcgee123 deleted the remove-rewire-test branch January 12, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdavidzhu hdavidzhu hdavidzhu approved these changes

@mlex mlex Awaiting requested review from mlex

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcgee123 @hdavidzhu