Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccessary and superfluous bounds #14

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Remove unneccessary and superfluous bounds #14

merged 1 commit into from
Mar 14, 2022

Conversation

SabrinaJewson
Copy link
Contributor

  • The AcceptFuture: Unpin bound is not necessary since they're only put in a FuturesUnordered which is always Unpin and accept !Unpin futures.
  • The A::Connection: AsyncRead + AsyncWrite bounds are not necessary since they're implied by the trait.
  • The A::Connection: Unpin bound isn't necessary; it's required by all current AsyncTls implementations but there's no theoretical reason an AsyncTls implementation couldn't exist without that bound.
  • The A::Connection: 'static bound isn't necessary, it's not like it's spawned in a task or anything.

@tmccombs tmccombs merged commit dc3e9f7 into tmccombs:main Mar 14, 2022
@tmccombs
Copy link
Owner

Thanks, I think some maybe most of this is legacy older versions of the code.

@SabrinaJewson SabrinaJewson deleted the relax-bounds branch March 19, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants