Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llms: Add fake package #935

Merged
merged 10 commits into from
Sep 13, 2024
Merged

llms: Add fake package #935

merged 10 commits into from
Sep 13, 2024

Conversation

devalexandre
Copy link
Contributor

@devalexandre devalexandre commented Jun 27, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@eliben
Copy link
Collaborator

eliben commented Jun 27, 2024

You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's not clear at all what and why this is doing.

Also, the code is full of Portuguese comments and strings, is this intentional?

@devalexandre
Copy link
Contributor Author

You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's not clear at all what and why this is doing.

Also, the code is full of Portuguese comments and strings, is this intentional?

sorry , I'll update to en and edit the list

@flc1125
Copy link

flc1125 commented Jul 23, 2024

I suggest adding a Generate interface to pass in, instead of responses []string.

Then implement a Default Generate to support it. This would allow for better customization and extensibility.

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. would be cool to support streaming.

Please leave source comments in english

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit 862451a into tmc:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants