-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llms: Add fake package #935
Conversation
You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's not clear at all what and why this is doing. Also, the code is full of Portuguese comments and strings, is this intentional? |
sorry , I'll update to en and edit the list |
I suggest adding a Then implement a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. would be cool to support streaming.
Please leave source comments in english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.