llms/anthropic: adds full support for messages api #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated this to remove the fatals from the stream processing. I think it's better to pass the errors back instead of crashing and just letting the user handle them. This is different than the other LLM implementations like OpenAI which I used as a guideline. |
tmc
approved these changes
Mar 21, 2024
|
|
||
| usage, ok := event["usage"].(map[string]interface{}) | ||
| if !ok { | ||
| return response, errors.New("invalid usage field type") |
There was a problem hiding this comment.
while an internal package, generally it's better to define these errors up top so calling code can use errors.Is checks.
tmc
reviewed
Mar 21, 2024
llms/anthropic/anthropicllm.go
Outdated
| token: os.Getenv(tokenEnvVarName), | ||
| baseURL: anthropicclient.DefaultBaseURL, | ||
| httpClient: http.DefaultClient, | ||
| useCompletionsAPI: true, |
There was a problem hiding this comment.
I'd actually like to default to the messages API
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.This adds full support for the new messages API including streaming.
It backwards compatible with client option flag for using message api.
It also updates the default model to 1.3 as 1.0 isn't supported by either completions or messages API.
Closes #695