Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleichenbacher fixes [0.7] #439

Merged
merged 5 commits into from
Dec 8, 2020
Merged

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Dec 7, 2020

Attempt fixing the Bleichenbacher side-channel leaks.

backport of the #438


This change is Reviewable

with M2Crypto we can process byte strings, and for padding/depadding
we need bytes, so don't convert back and forth between the
formats

also put all the integer to bytes conversion in a single place
for the implementations that can't handle bytes as input
@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Dec 7, 2020
@tomato42 tomato42 self-assigned this Dec 7, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 7, 2020

This pull request introduces 1 alert and fixes 2 when merging 2738f15 into acdde31 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Membership test with a non-container
  • 1 for Unused import

@tomato42 tomato42 merged commit c28d6d3 into tlslite-ng-0.7 Dec 8, 2020
@tomato42 tomato42 deleted the bleichenbacher-fixes-0.7 branch December 8, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant