desktop: allow paste-to-post for images in galleries #4584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes tlon-3863
At first, I attempted to implement this inapp/ui/components/Channel/index.tsx
, but I ended up implementing this in ChannelScreen using useUploadState directly and not using the attachment context because:1) It avoids race conditions between attachment state updates and upload operations (callingattachAssets
andwaitForAttachmentUploads
from the attachment context in succession was fraught).2) It works within component hierarchy constraints (ChannelScreen is a parent of AttachmentProvider and it feels like this functionality should be in ChannelScreen).
3) It provides granular control for auto-posting each image as a separate message immediately after upload completion
Open to ideas if anyone can think of a better approach, though.I added a new method to our attachment context that handles this case.