Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect nesting of child nodes when singularizeChildren is false #8

Closed
andrew-wharton opened this issue Jan 19, 2016 · 2 comments
Closed

Incorrect nesting of child nodes when singularizeChildren is false #8

andrew-wharton opened this issue Jan 19, 2016 · 2 comments

Comments

@andrew-wharton
Copy link

Created a unit test demonstrating the incorrect behaviour -> andrew-wharton@c53ff30

Should I create a pull request for you to add this unit test so the problem can be fixed? I'm not sure how to go about fixing it myself unfortunately...
@andrew-wharton andrew-wharton mentioned this issue Jan 19, 2016
Open
tlhunter added a commit that referenced this issue Feb 5, 2016
@tlhunter
Properly building children when not singularizing, fixes #8
26511ce
@tlhunter tlhunter mentioned this issue Feb 5, 2016
Merged
@tlhunter
Copy link
Owner

tlhunter commented Feb 5, 2016

This is fixed in a PR. Will bump MAJOR versions. Going to make some more MINOR changes then merge.

@andrew-wharton
Copy link
Author

Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew-wharton @tlhunter