This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Do not provide onChange prop by default #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| if (onChange) inputProps.onChange = | ||
| event => this.props.onChange(event.target.value); |
There was a problem hiding this comment.
Creating an anomymous function every render is not optimal. It's way better to keep the _handleChange ;)
There was a problem hiding this comment.
Sorry, I just got used to use react-hot-loader and now react-transform-hmr. So I avoid assigning methods on each instance.
There was a problem hiding this comment.
Let me know when it's fixed and I'll merge
|
Fixed |
tleunen
added a commit
that referenced
this pull request
Sep 29, 2015
Do not provide onChange prop by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #55