This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
fix dialog cancel handler, update tests, and update documentation #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got the exact same issue when trying to write test around that. |
tleunen
added a commit
that referenced
this pull request
Feb 24, 2016
fix dialog cancel handler, update tests, and update documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #221 as per latest discussion. I also updated the docs since to make the onCancel availability more obvious.
Regarding tests, I cannot exactly test the 'open' state as of right now. Since the native
open,showModal, and thecancelevent fired on pressing Escape can only be called when the dialog is mounted on real document. I only got element not in document error when I tried them. The very least I can do is to test if the listeners are attached and detached correctly.Cheers!
Permagate.